fix: fixed security vulnerabilities from SAST/DAST scans#1
Closed
natanim-kemal wants to merge 1 commit intomainfrom
Closed
fix: fixed security vulnerabilities from SAST/DAST scans#1natanim-kemal wants to merge 1 commit intomainfrom
natanim-kemal wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving the security and robustness of both the browser extension and the backend API. Major changes include switching API requests to HTTPS, enhancing backend security, and improving error handling.
Security and API Hardening:
src/api.py, including insecure endpoints and hardcoded secrets. [1] [2] [3]Input Validation and Safer Operations:
/logendpoint./lookupendpoint and replaced shell-based DNS lookups with safesocketcalls./logs/<filename>endpoint to prevent directory traversal and unauthorized file access.Frontend and API Communication:
background.js,popup.js). [1] [2]Other:
popup.html.