Skip to content

View Markdown Link DRAFT#23

Open
jpdevries wants to merge 1 commit into
modxcms:masterfrom
jpdevries:view-markdown-link
Open

View Markdown Link DRAFT#23
jpdevries wants to merge 1 commit into
modxcms:masterfrom
jpdevries:view-markdown-link

Conversation

@jpdevries

Copy link
Copy Markdown
Collaborator

Goal:
To make reviewing MAB DRAFTS more user friendly.

View Markdown Preview

@Mark-H

Mark-H commented Jun 29, 2017

Copy link
Copy Markdown
Contributor

schermafbeelding 2017-06-29 om 10 27 57

@jpdevries

jpdevries commented Jun 29, 2017

Copy link
Copy Markdown
Collaborator Author

@Mark-H

  • that's just a rich diff, it's still a diff
  • all that green in distracting
  • that feature isn't on mobile

Another advantage of having a link in the PR body is it makes it easier for someone to submit an edit to the PR author's fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants