Replace existing window when same window is added twice#128
Open
mogenson wants to merge 1 commit into
Open
Conversation
We currently ignore multiple add window events for the same window. But this might mean the existing window is invalid and tiling can fail when the new ignored window is focused. Replace the existing window with the new window for multiple add window events.
Contributor
|
Did this end up being necessary? |
Owner
Author
|
No, I thought this might be occurring with my terminal (WezTerm) changing the window ID when connecting to a remote ssh host. But after further investigation it does appear that old window is destroyed before the new window is added (even if it appears to be the same physical window on screen). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently ignore multiple add window events for the same window. But this might mean the existing window is invalid and tiling can fail when the new ignored window is focused. Replace the existing window with the new window for multiple add window events.