refactor(console): Inline script templates, remove /scripts endpoint#54
Merged
refactor(console): Inline script templates, remove /scripts endpoint#54
Conversation
Replace the hx-get="/scripts" runtime fetch with a static
{{template "scripts:buckets/objects.html" .}} include in index.html.
Since loadTemplates parses objects.html before index.html, the
{{define "scripts:..."}} block is already available at parse time.
This eliminates the /scripts endpoint, scripts.go, scriptTemplates
slice, and RegisterTemplateWithScripts — removing an HTTP round-trip
and the associated race condition on page load.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hx-get="/scripts"runtime fetch with a static{{template "scripts:buckets/objects.html" .}}include inindex.html.scripts.goalong withhandleScripts,scriptTemplates, andRegisterTemplateWithScripts.objects.goto useserver.RegisterTemplatedirectly.This works because
loadTemplatesparsesobjects.html(which contains the{{define "scripts:..."}}block) beforeindex.html, so the named template is available at parse time.What's removed
GET /scriptsendpointscripts.goRegisterTemplateWithScriptsserver.RegisterTemplatesufficeshx-get="/scripts"div{{template}}Test plan
go test ./...passesgolangci-lint run ./...clean/scriptsrequest in browser Network tab