revert single-curl fetch, keep scanlinks optimizations#3
Open
caiot5 wants to merge 2 commits intomolivil:masterfrom
Open
revert single-curl fetch, keep scanlinks optimizations#3caiot5 wants to merge 2 commits intomolivil:masterfrom
caiot5 wants to merge 2 commits intomolivil:masterfrom
Conversation
…/caiot5/warnick into feature/performance-optimization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out the Internet Archive handles big sites like microsoft.com, aol.com and so on differently from smaller ones, returning a direct 200 on bare domain roots instead of the usual redirect chain. The single-curl rewrite from the previous PR relies on the redirect chain to recover the real filename, so it silently fails on those sites and the crawl dies after the first page.
The original HEAD+redirect loop+wget pattern doesn't have this problem because wget always gets a fully-resolved URL with the real filename in it regardless of what IA does upstream.
Went back to the original geturl from 2.1.4. Kept the scanlinks speed improvements from the previous PR and also snuck in the LC_ALL=C fix for sites with non-ASCII filenames since it was already sitting in another open PR.