feat: [ts-starter #8] add script for bundle size analysis#12
Open
ehsanmmd wants to merge 2 commits into
Open
Conversation
ehsanmmd
force-pushed
the
feat/bundle-size-analysis
branch
from
March 23, 2024 07:35
19ba11e to
293dfa2
Compare
ehsanmmd
force-pushed
the
feat/bundle-size-analysis
branch
from
March 23, 2024 07:42
293dfa2 to
3c40bce
Compare
momesana
reviewed
Mar 23, 2024
| "stats": "webpack --mode production --profile --json > stats.json", | ||
| "bundle-analysis": "pnpm stats && pnpm dlx webpack-bundle-analyzer stats.json", | ||
| "bundle-stats": "webpack --mode production --profile --json > stats.json", | ||
| "show-bundle-analysis": "pnpm dlx webpack-bundle-analyzer stats.json", |
Owner
There was a problem hiding this comment.
Why should that help?
You almost always need to create a new stat file when showing the analysis. So it doesn't make sense to have a script running on an existing stats file. The stats is also short enough and doesn't need to be changed to bundle-stats IMO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.