Skip to content
This repository was archived by the owner on Oct 12, 2024. It is now read-only.

Improved python script#3

Open
CoolingJam wants to merge 2 commits intomon:masterfrom
CoolingJam:better-script
Open

Improved python script#3
CoolingJam wants to merge 2 commits intomon:masterfrom
CoolingJam:better-script

Conversation

@CoolingJam
Copy link

Noticed that the python script is pretty janky and fiddly, so I improved it a little by giving it a menu that gives the user a choice between converting from a video to a json file or from a json file to the bin file (no commenting needed now) and by making the script auto-create the apple_frames folder if it is missing. Also fixed a path inconsistency in the last lines of the script. Might aswell share my improvements.

@mon
Copy link
Owner

mon commented Dec 12, 2023

Hey, nice! Glad someone actually fixed up the python script somewhat 😅 However, this breaks my own workflow of re-running the script over and over to tweak the box generation algo. It'd be great if it had an argparse parser so I could automate it, but fall back to user-provided values otherwise.

@CoolingJam
Copy link
Author

Sure, I'll send a commit when I have time.

@CoolingJam
Copy link
Author

This commit should do the trick, adding an optional -i (also --input) arg, which skips the input() calls. This should make it fairly trivial to automate it with a batch script.

@mon
Copy link
Owner

mon commented Oct 12, 2024

Thank you for this work, but I've realised I simply don't have the bandwidth to work through the PRs at the moment, so I'm archiving the entire repo. I'll leave this PR open so anyone can see "hey there's this cool branch with better features".

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants