Skip to content

Fixed read-only mode not able to retrieve any board data. Added execution-level protection while in read-only mode. #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dahuan-Ou wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed read-only mode not able to retrieve any board data. Added execution-level protection while in read-only mode. #116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/agent-toolkit/src/mcp/toolkit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ export class MondayAgentToolkit extends McpServer {
private readonly mondayApiClient: ApiClient;
private readonly mondayApiToken: string;
private readonly dynamicToolManager: DynamicToolManager = new DynamicToolManager();
private readonly readOnlyMode: boolean;

/**
* Creates a new instance of the Monday Agent Toolkit
Expand All @@ -37,6 +38,7 @@ export class MondayAgentToolkit extends McpServer {

this.mondayApiClient = this.createApiClient(config);
this.mondayApiToken = config.mondayApiToken;
this.readOnlyMode = config.toolsConfiguration?.readOnlyMode ?? false;

this.registerTools(config);
}
Expand Down Expand Up @@ -116,6 +118,14 @@ export class MondayAgentToolkit extends McpServer {
async (args: any, _extra: any) => {
try {
let result;

// Read-only mode protection: prevent WRITE and ALL_API tools from executing
if (this.readOnlyMode && (tool.type === 'write' || tool.type === 'all_api')) {
throw new Error(
`Tool '${tool.name}' cannot be executed in read-only mode. This tool performs write/modification operations which are disabled in read-only mode.`
);
}

if (inputSchema) {
const parsedArgs = z.object(inputSchema).safeParse(args);
if (!parsedArgs.success) {
Expand Down
3 changes: 0 additions & 3 deletions packages/agent-toolkit/src/utils/tools/tools-filtering.utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,6 @@ export const getFilteredToolInstances = (
if (config.mode === ToolMode.API && config.enableDynamicApiTools === false) {
shouldFilter = shouldFilter || toolInstance.type === ToolType.ALL_API;
}
if (config.readOnlyMode) {
shouldFilter = shouldFilter || toolInstance.type !== ToolType.READ;
}
if (config.include) {
shouldFilter = shouldFilter || !config.include?.includes(toolInstance.name);
} else if (config.exclude) {
Expand Down