fix(table): prevent unnecessary scrollbar in table body#3135
Open
noyshlomo wants to merge 1 commit intomondaycom:masterfrom
Open
fix(table): prevent unnecessary scrollbar in table body#3135noyshlomo wants to merge 1 commit intomondaycom:masterfrom
noyshlomo wants to merge 1 commit intomondaycom:masterfrom
Conversation
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
This PR fixes an issue where the table body always displayed a vertical scrollbar, even when there was no overflow content.
Changed .tableBody height from 100% to calc(100% - var(--table-row-size))
This adjustment ensures the table body height accounts for the header row and only shows the scrollbar when needed
Tested locally in Storybook to confirm that the scrollbar now only appears when the content exceeds the available space
I have read the Contribution Guide for this project.
Resolves #3127
PR Type
Bug fix
Description
Fixed unnecessary vertical scrollbar in table body
Adjusted height calculation to account for header row
Scrollbar now only appears when content overflows
Diagram Walkthrough
File Walkthrough
TableBody.module.scss
Fix table body height calculationpackages/core/src/components/Table/TableBody/TableBody.module.scss
100%tocalc(100% - var(--table-row-size))