Skip to content

fix(ButtonGroup): apply fullWidth to root element#3187

Closed
YehudaMenahem wants to merge 1 commit intomondaycom:masterfrom
YehudaMenahem:fix/button-group-fullwidth
Closed

fix(ButtonGroup): apply fullWidth to root element#3187
YehudaMenahem wants to merge 1 commit intomondaycom:masterfrom
YehudaMenahem:fix/button-group-fullwidth

Conversation

@YehudaMenahem
Copy link

@YehudaMenahem YehudaMenahem commented Nov 23, 2025

User description

This fix applies the missing fullWidth class to the ButtonGroup root element.
The SCSS already defines .fullWidth { flex: 1 }, which makes sense here since
flex: 1 allows the ButtonGroup to expand proportionally inside its flex container.
This resolves the issue where fullWidth had no effect in Storybook.

  • I have read the Contribution Guide.

Resolves #3130


PR Type

Bug fix


Description

  • Apply missing fullWidth class to ButtonGroup root element

  • Enables flex: 1 styling for proportional expansion

  • Resolves fullWidth prop having no effect in Storybook


Diagram Walkthrough

flowchart LR
  A["ButtonGroup component"] -- "add fullWidth class" --> B["Root div with flex: 1 styling"]
  C["fullWidth prop"] -- "conditional rendering" --> B
Loading

File Walkthrough

Relevant files
Bug fix
ButtonGroup.tsx
Add fullWidth class binding to root element                           

packages/core/src/components/ButtonGroup/ButtonGroup.tsx

  • Added fullWidth prop to the conditional className binding
  • Applies styles.fullWidth class when fullWidth prop is true
  • Enables the existing SCSS rule flex: 1 to take effect
+1/-1     

@YehudaMenahem YehudaMenahem requested a review from a team as a code owner November 23, 2025 06:36
@qodo-free-for-open-source-projects
Copy link
Contributor

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ No major issues detected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: ButtonGroup fullWidth prop has no affect in storybook

1 participant