fix(ButtonGroup): apply fullWidth to root element#3187
Closed
YehudaMenahem wants to merge 1 commit intomondaycom:masterfrom
Closed
fix(ButtonGroup): apply fullWidth to root element#3187YehudaMenahem wants to merge 1 commit intomondaycom:masterfrom
YehudaMenahem wants to merge 1 commit intomondaycom:masterfrom
Conversation
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
This fix applies the missing
fullWidthclass to the ButtonGroup root element.The SCSS already defines
.fullWidth { flex: 1 }, which makes sense here sinceflex: 1allows the ButtonGroup to expand proportionally inside its flex container.This resolves the issue where
fullWidthhad no effect in Storybook.Resolves #3130
PR Type
Bug fix
Description
Apply missing
fullWidthclass to ButtonGroup root elementEnables flex: 1 styling for proportional expansion
Resolves fullWidth prop having no effect in Storybook
Diagram Walkthrough
File Walkthrough
ButtonGroup.tsx
Add fullWidth class binding to root elementpackages/core/src/components/ButtonGroup/ButtonGroup.tsx
fullWidthprop to the conditional className bindingstyles.fullWidthclass whenfullWidthprop is trueflex: 1to take effect