Removal of many partial functions related to head.#157
Open
jcmartin wants to merge 2 commits intomongodb-haskell:masterfrom
Open
Removal of many partial functions related to head.#157jcmartin wants to merge 2 commits intomongodb-haskell:masterfrom
jcmartin wants to merge 2 commits intomongodb-haskell:masterfrom
Conversation
…rror code, use Nothing not zero.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is focused on removing warnings about partial functions related to head. In addition, when the error code is not present, we use Nothing instead of using 0 to disambiguate an error code missing versus no error.
This pull request is meant to be as simple as possible. There are partial function warnings coming up in Internal.Protocol. However, these are a bit more tedious to remove.