chore: update engines requirement in the repo - #768
Merged
Conversation
gribnoysup
commented
May 29, 2026
| "email": "compass@mongodb.com" | ||
| }, | ||
| "engines": { | ||
| "node": ">=14.17.5", |
Collaborator
Author
There was a problem hiding this comment.
Tell me if you think there's a reason for us to keep it so low 🤔
Collaborator
There was a problem hiding this comment.
For the top-level package.json? No, doesn't matter
For individual packages? If we think there's realistic external usage, bumping the minimum Node.js version is kind of a breaking change
Collaborator
Author
There was a problem hiding this comment.
Yeah, no, this makes sense, but we only have a top-level engines in the monorepo, none of the packages specify their own. And we don't have versions that are lower in the test matrix, so if there are some requirements there, maybe we should add some for visibility
|
Coverage is 78.63% — update-engines-requirement-npm-11-node-22 into main. No base build found for |
nbbeeken
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preparing for trusted publishing, minimum age, allow scripts, etc.