Skip to content

feat(aggregation-stage-icons): add aggregation stage icons package - #769

Merged
Anemy merged 2 commits into
mainfrom
add-stage-icons
Jun 2, 2026
Merged

feat(aggregation-stage-icons): add aggregation stage icons package#769
Anemy merged 2 commits into
mainfrom
add-stage-icons

Conversation

@Anemy

@Anemy Anemy commented Jun 1, 2026

Copy link
Copy Markdown
Member

Having icons in the aggregation stage select options in Compass will help folks find their stages faster and add some visually descriptive information for the stages. I'm opening the pr here instead of Compass as I figure as the icons could be used in another place down the line, like VSCode. If folks feel it's better in Compass let me know! Happy to move it over.

I haven't made an icon react package library before, let me know if there are any suggestions around exporting/typing. Here's LG's icon package as a reference.

This list of icons isn't designed to be an exhaustive list of all of the stages. The consumer will have to have fallbacks for any unsupported stages.

Misba designed these! With some AI assistance along the way.

Here's how it will look in Compass:
Screenshot 2026-05-29 at 04 53 47

All of the icons * some of them have been tweaked since this screenshot was taken
Screenshot 2026-06-01 at 17 53 28

@coveralls

coveralls commented Jun 1, 2026

Copy link
Copy Markdown

Coverage Status

coverage: 72.92% (-5.7%) from 78.63% — add-stage-icons into main

@gribnoysup gribnoysup left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but wouldn't it make more sense to just have them close to constants so that we know when to add a new one?

@Anemy

Anemy commented Jun 2, 2026

Copy link
Copy Markdown
Member Author

@gribnoysup I was thinking about adding it there and decided against it just to keep react out of mongodb-constants. I don't feel too strongly so I'm happy moving it there if you'd like. Eventually I think it makes the most sense to be in the design systems. I've asked about that in their slack channel https://mongodb.slack.com/archives/CFFA5BS79/p1780416541946559

@Anemy
Anemy enabled auto-merge (squash) June 2, 2026 19:25
@Anemy
Anemy merged commit 35717a8 into main Jun 2, 2026
37 of 42 checks passed
@Anemy
Anemy deleted the add-stage-icons branch June 2, 2026 19:25
@gribnoysup

Copy link
Copy Markdown
Collaborator

FWIW I don't think we need to package React with it like that, svg paths are already very portable, but no strong opinions on that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants