test(NODE-7498): remove 3 linux-specific tests from Windows Nodeless variant#4909
test(NODE-7498): remove 3 linux-specific tests from Windows Nodeless variant#4909
Conversation
There was a problem hiding this comment.
Pull request overview
Removes Linux-only test tasks that were mistakenly included in the Windows “nodeless” test matrix, preventing those suites from running in an incompatible environment.
Changes:
- Dropped
test-rapid-load-balanced,test-latest-load-balanced, andtest-auth-kerberosfrom thenodelessTaskstask list generator. - Removed the same three tasks from the relevant Windows nodeless build variant task lists in Evergreen config.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .evergreen/generate_evergreen_tasks.js | Removes Linux-specific test task names from the shared nodelessTasks list used for task generation. |
| .evergreen/config.yml | Removes those tasks from the affected buildvariants so Windows nodeless no longer schedules them. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| 'test-latest-server-v1-api', | ||
| 'test-x509-authentication', | ||
| 'test-atlas-connectivity', | ||
| 'test-rapid-load-balanced', | ||
| 'test-latest-load-balanced', | ||
| 'test-auth-kerberos', | ||
| 'test-auth-ldap', | ||
| 'test-socks5-csfle', | ||
| 'test-socks5-tls', |
There was a problem hiding this comment.
The PR description says this is specific to the Windows Nodeless variant, but this change removes tasks from the shared nodelessTasks list (which may be consumed by multiple nodeless variants). If Windows-only behavior is intended, consider scoping these removals to the Windows nodeless variant definition (or introducing a Windows-specific nodeless task list) so Linux/macOS nodeless scheduling isn’t inadvertently changed.
There was a problem hiding this comment.
This is true @PavelSafronov , do we want to remove those tests from both platforms? If so - can you please update the PR title (commit message will be squashed in merge).
tadjik1
added
the
Primary Review
tadjik1
left a comment
tadjik1
left a comment
There was a problem hiding this comment.
Thanks @PavelSafronov for quick reaction! Please take a look at the first comment of copilot. The rest is fine.
Description
Summary of Changes
3 Linux-specific tests were incorrectly added to list of tests to run in Windows Nodeless environment. Removing these Linux-specific tests.
Notes for Reviewers
What is the motivation for this change?
Release Highlight
Release notes highlight
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript