Skip to content

fix(funbox): skip wikipedia section fetch when leaving the test page (@henrikhhag)#8267

Open
henrikhhag wants to merge 1 commit into
monkeytypegame:masterfrom
henrikhhag:fix/wikipedia-funbox-background-restart
Open

fix(funbox): skip wikipedia section fetch when leaving the test page (@henrikhhag)#8267
henrikhhag wants to merge 1 commit into
monkeytypegame:masterfrom
henrikhhag:fix/wikipedia-funbox-background-restart

Conversation

@henrikhhag

Copy link
Copy Markdown

Problem: every time you leave the test page, the app runs a background-restart of the test, and if the wikipedia-funbox is active, then the restart makes a unnecessary network call to Wikipedia in the background. And if that call fails, then the global loading indicator will just stand there without anyone seeing why.

#8032
From the issue #8032, in comments section, @Leonabcd123 traces the issue directly to the afterHide-hook

The fix is to make a new flag (skipFunboxSection) that lets this specific background-restart jump over the network, while normal use of test page is unchanged.

For testing I wrote a Vitest-test that confirms the network call doesn't happen with the flag, and continues without it. Also ran the full frontend test suite (1047 tests) to check for regressions — all passing.

  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #8032

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend User interface or web stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Getting a loading animation when switching to settings page with wikipedia funbox enabled

2 participants