fix(funbox): skip wikipedia section fetch when leaving the test page (@henrikhhag)#8267
Open
henrikhhag wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: every time you leave the test page, the app runs a background-restart of the test, and if the wikipedia-funbox is active, then the restart makes a unnecessary network call to Wikipedia in the background. And if that call fails, then the global loading indicator will just stand there without anyone seeing why.
#8032
From the issue #8032, in comments section, @Leonabcd123 traces the issue directly to the afterHide-hook
The fix is to make a new flag (skipFunboxSection) that lets this specific background-restart jump over the network, while normal use of test page is unchanged.
For testing I wrote a Vitest-test that confirms the network call doesn't happen with the flag, and continues without it. Also ran the full frontend test suite (1047 tests) to check for regressions — all passing.
Closes #8032