feat(leaderboard): show current daily standing on the result page (@henrikhhag)#8268
Open
henrikhhag wants to merge 1 commit into
Open
feat(leaderboard): show current daily standing on the result page (@henrikhhag)#8268henrikhhag wants to merge 1 commit into
henrikhhag wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(@henrikhhag)
Description
Idea: Today the daily leaderboard rankings on the results page (after you are done with a test) shows only when you actually hit top 1000, or you improve your previous time to qualify for top 1000, but something I always wanted was to showcase at all time when I'm doing tests in top 15 sec/60 sec, the time I have currently holding for top 1000. And yes you can always just go into the leaderboard page and see where you at, but I find it better to just showcase it after you have done a test.
Solution: Add a new setting "show daily leaderboard standing" (which will be off by default), that when a run doesn't improve your best score, showcases what you "have to beat". It's more toned down to distinguish it from an actually new placement, and also showcases wpm/acc in small letters under.
Tests: I tested this manually, towards a local backend/MongoDB/Redis/Firebase, and it works and looks good in my opinion.
Checks
packages/schemas/src/languages.tsfrontend/src/ts/constants/languages.tsfrontend/static/languagespackages/schemas/src/themes.tsfrontend/src/ts/constants/themes.tsfrontend/static/themespackages/schemas/src/layouts.tsfrontend/static/layoutsfrontend/static/webfontspackages/schemas/src/fonts.tsfrontend/src/ts/constants/fonts.ts