fix(quotes): prevent wrong quote length when moderator edits quote (@HmonWutt)#8274
Open
HmonWutt wants to merge 1 commit into
Open
fix(quotes): prevent wrong quote length when moderator edits quote (@HmonWutt)#8274HmonWutt wants to merge 1 commit into
HmonWutt wants to merge 1 commit into
Conversation
github-actions
Bot
added
the
waiting for review
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes quote-approval flow so length is derived from the approved (possibly edited) quote text, matching what gets written to the quotes JSON.
Changes:
- Compute
approvedTextonce and reuse fortext+length - Set
quote.lengthfromapprovedText.lengthinstead of the originaltargetQuote.text.length
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a moderator edits a quote, the length of quote was calculated from the original (unedited) text instead of the new (edited) quote text.