Remove unused AgentScript model and constants - #7
Open
mrostan wants to merge 2 commits into
Open
Conversation
The agent-script execution feature is being removed across the agent and data-collector (flagged by customer security reviews and no longer used). Removes the AgentScript / AgentScriptModule dataclasses and the AGENT_SCRIPT_ENTRYPOINT / AGENT_SCRIPT_BUILTIN_MODULES constants, which were only consumed by that feature. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2 tasks
santiagoaguiar
left a comment
There was a problem hiding this comment.
Reviewed for completeness and blast radius — no findings, this is clean.
- The diff removes exactly
AgentScriptModule,AgentScript,AGENT_SCRIPT_ENTRYPOINT, andAGENT_SCRIPT_BUILTIN_MODULES; a full-branch grep confirms zero remaining references.AgentScriptwas a standaloneAgentOperationsubclass — nothing inserde.pyor the operation dispatch path special-cases it. - Checked all agent-base consumers across the org (apollo-agent, agent-common, hermes-agent, sna-artemis-agent, and data-collector transitively via
mcd-agent): only apollo-agent ever imported these symbols, and apollo-agent #315 removes those imports. The data-collector'sAgentScriptis its own local dataclass, removed by data-collector #2414. All consumers use exact version pins, so merging this breaks no one — the ordering note in the description is accurate. - Only operational note: tag a release (v0.0.5) after merge so apollo-agent can bump its pin once #315 lands.
santiagoaguiar
approved these changes
Jul 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's new?
Removes the
AgentScript/AgentScriptModuledataclasses and theAGENT_SCRIPT_ENTRYPOINT/AGENT_SCRIPT_BUILTIN_MODULESconstants.These were only consumed by the agent script-execution feature, which is being
removed across apollo-agent and data-collector (flagged by customer
security reviews and confirmed unused by the team). Within agent-base these
symbols had no other references.
Related PRs
/api/v1/agent/execute_scriptendpoint + RestrictedPython executorTesting
Merge ordering
Part of a 3-repo change. Safe to merge independently, but the coordinated dev
rollout is: agent-base + apollo-agent first, then bump data-collector's
mcd-agent/agent-basepin.🤖 Generated with Claude Code