Fix categorical ALE crash with high-cardinality features (#86)#87
Merged
Conversation
When bootstrapping categorical ALE, different bootstrap samples may contain different subsets of categories, producing ragged arrays that numpy cannot stack. Fix by: - Computing the full category set from the original data upfront - Reindexing each bootstrap's ALE values to the full category set (missing categories filled with NaN) - This ensures all bootstrap iterations have consistent array shapes Also add 3 unit tests for low/medium/high cardinality categorical ALE. Closes #86 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When bootstrapping categorical ALE, different bootstrap samples may contain different subsets of categories, producing ragged arrays that numpy cannot stack. Fix by:
Also add 3 unit tests for low/medium/high cardinality categorical ALE.
Closes #86