Skip to content

[Snyk] Security upgrade diff from 3.5.0 to 8.0.3#41

Open
monzerfoda wants to merge 1 commit into
masterfrom
snyk-fix-f2977a91c38297e3d19f9e81fc3306d3
Open

[Snyk] Security upgrade diff from 3.5.0 to 8.0.3#41
monzerfoda wants to merge 1 commit into
masterfrom
snyk-fix-f2977a91c38297e3d19f9e81fc3306d3

Conversation

@monzerfoda
Copy link
Copy Markdown
Owner

snyk-top-banner

Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.

Snyk changed the following file(s):

  • packages/components/package.json

Vulnerabilities that will be fixed with an upgrade:

Issue Score
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-DIFF-14917201
  708  

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.
  • This PR was automatically created by Snyk using the credentials of a real user.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.

For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic


Learn how to fix vulnerabilities with free interactive lessons:

🦉 Regular Expression Denial of Service (ReDoS)

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 62badacaf5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

"classnames": "^2.2.5",
"clipboard": "^2.0.1",
"diff": "^3.5.0",
"diff": "^8.0.3",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update lockfile so diff actually upgrades

Changing packages/components/package.json alone doesn’t update the resolved version in package-lock.json, which still pins diff to 3.5.0. Any install that uses the lockfile (e.g. npm ci in CI or contributors) will continue to pull 3.5.0 and the ReDoS fix won’t be applied, so the security upgrade is effectively skipped in those environments. The lockfile needs to be updated alongside this dependency bump to make the upgrade take effect.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants