Skip to content

[codex] fix moon fmt and info drift#394

Closed
bobzhang wants to merge 1 commit into
mainfrom
codex/fix-moon-format-info
Closed

[codex] fix moon fmt and info drift#394
bobzhang wants to merge 1 commit into
mainfrom
codex/fix-moon-format-info

Conversation

@bobzhang

@bobzhang bobzhang commented May 27, 2026

Copy link
Copy Markdown
Contributor

Summary

Split the repo-wide moon fmt and moon info updates out from #392.

  • apply current moon fmt output, including with fn / trait fn syntax updates
  • migrate moon.mod.json files to moon.mod for the root module, examples module, and process test programs module
  • add src/process/test_programs/moon.work so nested helper programs resolve the local workspace after migration
  • update helper executable paths and tests that referenced moon.mod.json
  • update the format workflow to run the nested process test workspace with moon -C src/process/test_programs fmt
  • update src/io/pkg.generated.mbti from moon info

Validation

  • moon clean && moon -C src/process/test_programs clean
  • moon fmt
  • moon -C src/process/test_programs fmt
  • moon info
  • moon check --deny-warn
  • moon check --target js --deny-warn
  • moon -C examples check --deny-warn
  • moon -C src/process/test_programs check --deny-warn
  • MOONBIT_ASYNC_CHECK_FD_LEAK=1 moon test src/fs/access_test.mbt src/stdio/stdio_test.mbt examples/http_file_server/server_wbtest.mbt
  • git diff --check

Notes

This intentionally excludes the remaining timing-sensitive src/fs/lock_test.mbt race fix from #392, except for the helper path update required by the manifest migration.

@bobzhang bobzhang marked this pull request as ready for review May 27, 2026 13:17
@bobzhang bobzhang force-pushed the codex/fix-moon-format-info branch from 37a9c62 to 7b2c88b Compare May 27, 2026 13:26

Copy link
Copy Markdown
Contributor Author

CI status after the split/update: all checks are green.

The first coverage-windows attempt hit a transient timing threshold in http/request_test.mbt (request cancellation took too long: 370ms). I reran the failed coverage workflow; the rerun passed, including coverage-windows and display-coverage-result.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 360

Coverage increased (+0.05%) to 79.332%

Details

  • Coverage increased (+0.05%) from the base build.
  • Patch coverage: 1 uncovered change across 1 file (1 of 2 lines covered, 50.0%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
src/websocket/deprecated.mbt 1 0 0.0%
Total (2 files) 2 1 50.0%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 4190
Covered Lines: 3324
Line Coverage: 79.33%
Coverage Strength: 80348.89 hits per line

💛 - Coveralls

Copy link
Copy Markdown
Contributor Author

I split the fn syntax portion into #395 so it can be reviewed/merged separately.

Once #395 lands, this PR can be rebased on main and its diff should drop the with fn / trait fn syntax churn, leaving the formatter/manifest/workflow/test-helper changes here.

@Guest0x0

Copy link
Copy Markdown
Collaborator

close as completed

@Guest0x0 Guest0x0 closed this May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants