Add wasm realpath bindings#459
Draft
peter-jerry-ye wants to merge 2 commits into
Draft
Conversation
Coverage Report for CI Build 644Coverage increased (+0.04%) to 77.171%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
peter-jerry-ye
force-pushed
the
codex/realpath-host-bindings
branch
from
d9bd80e to
060cc6e
Compare
peter-jerry-ye
force-pushed
the
codex/realpath-host-bindings
branch
from
060cc6e to
ec75248
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR wires the wasm async bindings for
realpathby adding the missing thread-pool job imports and the event-loop filesystem wrapper.Why
The native async package already exposes
realpath, but the wasm-specific thread-pool bindings still had placeholders. That prevented the wasm host implementation from being reached through the package API.Why this is correct
The wasm wrapper mirrors the existing native flow: encode the input path, run the
realpathworker job, fetch the returnedc_bufferhandle, and decode it through@os_string.Scope
The change is limited to the wasm event-loop and thread-pool binding files for
realpath.