Move pipe nonblocking setup to runtime#486
Conversation
Coverage Report for CI Build 792Coverage increased (+0.04%) to 77.202%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
03cd39a to
ba0821b
Compare
💡 Codex ReviewThe Line 119 in ba0821b When ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ba0821b to
0e7d8de
Compare
Why
Pipe async-end flags should be handled by the runtime side that creates the descriptors. Keeping the old MoonBit-side nonblocking path duplicates responsibility and keeps wasm pipe setup coupled to a platform check.
What
fd_util/set_nonblocking/uniximport and MoonBit helper fromfd_util.fd_util/pipe.Correctness
The runtime pipe import already receives both async-end flags before returning descriptors, so it can set descriptor mode at creation time. This leaves the wasm MoonBit code as a thin caller and avoids changing native async code.
Scope
This branch is based on
mainand only changes the wasm fd-util pipe path. The moonrun counterpart keeps the old wasm import ABI as a no-op for older guests until the compatibility shim is removed later.