Conversation
Stabilize Jira fast import & ensure user exist when computing metric for a user
knowbased
reviewed
Oct 23, 2025
Comment on lines
44
to
46
| userMergeRequests := self | ||
| loadMergeRequestsSince: (period at: #since) | ||
| until: (period at: #until) |
Collaborator
There was a problem hiding this comment.
LGTM
Just here you’re storing the result of loadMergeRequestSince in a variable called userMergeRequest, but it actually contains all merge requests — not just the user’s. It produce the intended result, but maybe the variable name could be a bit confusing when reading the calculate method
Member
Author
There was a problem hiding this comment.
fixed in bb78c65
I think it could have created bugs with the ifNil: [ self load]
Should add a test on that in the future
knowbased
approved these changes
Nov 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The metric
MergedMergeRequestMetricis used to count the number of MR merged by a user.Another metric is the number of merge request created by user that is close. This metric would point out the number of initiated work by a user that ends to a concrete contribution in the project.
I propose to rename
MergedMergeRequestMetricintoMergeRequestMergedByUserMetricTestAnd to use
MergedMergeRequestMetricto represent the number of merge request created by a user that is merged at the endI updated the tests accordingly (and created new ones)