Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting
| void DebugChunkSourceGenerator::Stop() { | ||
| if (!worker_.joinable()) return; | ||
| worker_.request_stop(); | ||
| worker_.join(); |
There was a problem hiding this comment.
Prevent Stop() from hanging on full output queue
Stop() only calls request_stop() and joins the thread, while the worker loop writes via blocking producer.Put (line 92) and never closes the queue. If a downstream stage has stopped and the queue fills, the worker blocks inside Put and can’t observe the stop token, causing Stop() to block indefinitely and preventing the loader from shutting down. Closing the queue or the producer before joining would let the worker unblock even when no consumer is draining.
Useful? React with 👍 / 👎.
Summary
Testing
just pre-commithttps://chatgpt.com/codex/tasks/task_e_68e101e81f748331a689058f164ee77d