Skip to content

[HF Datasets] Improve file download #975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lhoestq wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[HF Datasets] Improve file download #975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
52d04e0
Update file download implementation
lhoestq Feb 11, 2026
bacf9d8
use hffs.download for simplicity
lhoestq Feb 11, 2026
f3a0ccb
Update huggingface_hub dependency version
lhoestq Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@
]

extra_deps['hf'] = [
'huggingface_hub>=0.23.4,<1.4',
'huggingface_hub>=1.2.1,<1.4',
]

extra_deps['testing'] = [
Expand Down
12 changes: 2 additions & 10 deletions streaming/base/storage/download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,17 +502,9 @@ def clean_up(self) -> None:

def _download_file_impl(self, remote: str, local: str, timeout: float) -> None:
"""Implementation of the download function for a file."""
from huggingface_hub import hf_hub_download
from huggingface_hub import hffs

_, _, _, repo_org, repo_name, path = remote.split('/', 5)
local_dirname = os.path.dirname(local)
hf_hub_download(repo_id=f'{repo_org}/{repo_name}',
filename=path,
repo_type='dataset',
local_dir=local_dirname)

downloaded_name = os.path.join(local_dirname, path)
os.rename(downloaded_name, local)
hffs.download(remote, local)


class AzureDownloader(CloudDownloader):
Expand Down