Corrected the property name

[ghost]

Summary by CodeRabbit

• Chores
  • Updated service endpoint configuration properties to use domain-based definitions, affecting identity repository, authentication, and credential services for improved environment consistency.

[coderabbitai]

Walkthrough

Configuration properties in the identity plugin are refactored from URL-based to domain-based organization. Multiple service endpoints for identity management, key management, credential requests, and authentication mechanisms are updated to derive from new domain-based properties instead of full URLs.

Changes

Cohort / File(s)

Summary

Domain-based Property Refactoring mosip-identity-plugin/src/main/resources/application.properties

Replaces service base URLs (mosip.esignet.*.url) with domain properties (mosip.esignet.*.domain) and updates all dependent endpoint configurations (IDA, Signup, Masterdata, identity repository, key management, credential requests, ID generator, and file server). Rewrites KYC/auth URLs including certificate, exchange, OTP, identity key-binding, and audit-manager endpoints to use domain-based composition. Adds environment-specific domain variants for iframe-like URL construction.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A rabbit hops through config so fine,
Where domains replace each URL line,
From mosip.esignet with care we refine,
Service endpoints now tidily align! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Corrected the property name' is vague and does not specifically describe the main changes, which involve a comprehensive refactoring from URL-based to domain-based property names across multiple service endpoints.	Use a more specific title that captures the scope of changes, such as 'Refactor service URLs from URL-based to domain-based properties' or 'Update service endpoint configuration to use domain properties'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

You can customize the tone of the review comments and chat replies.

Configure the tone_instructions setting to customize the tone of the review comments and chat replies. For example, you can set the tone to Act like a strict teacher, Act like a pirate and more.

[coderabbitai]

🧹 Nitpick comments (1)

mosip-identity-plugin/src/main/resources/application.properties (1)

48-48: Consider centralizing repeated masterdata base path.

${mosip.esignet.masterdata.domain}/v1/masterdata is repeated in multiple properties; a shared base property would reduce drift risk in future edits.

Refactor sketch

+mosip.esignet.masterdata.base-url=${mosip.esignet.masterdata.domain}/v1/masterdata
-mosip.signup.idrepo.schema-url=${mosip.esignet.masterdata.domain}/v1/masterdata/idschema/latest?schemaVersion=
+mosip.signup.idrepo.schema-url=${mosip.esignet.masterdata.base-url}/idschema/latest?schemaVersion=
-mosip.signup.mosipid.get-ui-spec.endpoint=${mosip.esignet.masterdata.domain}/v1/masterdata/uispec/esignet-signup/latest?type=schema
+mosip.signup.mosipid.get-ui-spec.endpoint=${mosip.esignet.masterdata.base-url}/uispec/esignet-signup/latest?type=schema
-mosip.signup.mosipid.dynamic-fields.endpoint=${mosip.esignet.masterdata.domain}/v1/masterdata/dynamicfields?pageNumber=%d&pageSize=%d
+mosip.signup.mosipid.dynamic-fields.endpoint=${mosip.esignet.masterdata.base-url}/dynamicfields?pageNumber=%d&pageSize=%d
-mosip.signup.mosipid.doc-types-category.endpoint=${mosip.esignet.masterdata.domain}/v1/masterdata/applicanttype/000/languages?languages=eng
+mosip.signup.mosipid.doc-types-category.endpoint=${mosip.esignet.masterdata.base-url}/applicanttype/000/languages?languages=eng

Also applies to: 58-58, 60-60, 63-63

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@mosip-identity-plugin/src/main/resources/application.properties` at line 48,
Create a new shared base property (e.g.,
mosip.masterdata.base=${mosip.esignet.masterdata.domain}/v1/masterdata) and
update all properties that currently inline
`${mosip.esignet.masterdata.domain}/v1/masterdata`—including
mosip.signup.idrepo.schema-url and the other entries flagged in the file—to
reference the new base property (e.g.,
${mosip.masterdata.base}/idschema/latest?schemaVersion=) so the repeated
masterdata path is centralized and easier to maintain.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@mosip-identity-plugin/src/main/resources/application.properties`:
- Line 48: Create a new shared base property (e.g.,
mosip.masterdata.base=${mosip.esignet.masterdata.domain}/v1/masterdata) and
update all properties that currently inline
`${mosip.esignet.masterdata.domain}/v1/masterdata`—including
mosip.signup.idrepo.schema-url and the other entries flagged in the file—to
reference the new base property (e.g.,
${mosip.masterdata.base}/idschema/latest?schemaVersion=) so the repeated
masterdata path is centralized and easier to maintain.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 170f26cf-903a-4a01-b24e-84dd482509da

📥 Commits

Reviewing files that changed from the base of the PR and between 11fea50 and c800d7b.

📒 Files selected for processing (1)

• mosip-identity-plugin/src/main/resources/application.properties