Skip to content

added debug logger for send-otp response#201

Merged
anushasunkada merged 1 commit intomosip:developfrom
nandhu-kumar:develop-local1
Apr 3, 2026
Merged

added debug logger for send-otp response#201
anushasunkada merged 1 commit intomosip:developfrom
nandhu-kumar:develop-local1

Conversation

@nandhu-kumar
Copy link
Copy Markdown

@nandhu-kumar nandhu-kumar commented Apr 2, 2026

Summary by CodeRabbit

  • Chores
    • Optimized internal logging to reduce verbosity while maintaining necessary diagnostic information.

Signed-off-by: Nandhukumar <nandhukumare@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 2, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 9876d650-6af6-42ed-89cd-9a7c2146f0be

📥 Commits

Reviewing files that changed from the base of the PR and between 02be020 and 893d5b0.

📒 Files selected for processing (1)
  • mosip-identity-plugin/src/main/java/io/mosip/esignet/plugin/mosipid/service/HelperService.java

Walkthrough

The pull request modifies logging behavior in the sendOTP() method, replacing two information-level logs with a single debug-level log. The request/response validation logic and method return values remain unchanged.

Changes

Cohort / File(s) Summary
Logging Adjustment
mosip-identity-plugin/src/main/java/io/mosip/esignet/plugin/mosipid/service/HelperService.java
Changed successful IDA send-OTP response logging from two info logs (JSON serialization + raw response) to one debug log of the raw response object.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A hop, a skip, a log refined,
From info down to debug's mind,
One quiet line now takes the stage,
Less noise upon the service page! 🌙✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: converting info logs to a debug log for the send-OTP response in HelperService.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Timed out fetching pipeline failures after 30000ms


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@anushasunkada anushasunkada merged commit 4fbedf6 into mosip:develop Apr 3, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants