Remove inline for io_{cancel,submit}_error#54
Open
jmcarcell wants to merge 1 commit intomosquito:masterfrom
Open
Remove inline for io_{cancel,submit}_error#54jmcarcell wants to merge 1 commit intomosquito:masterfrom
jmcarcell wants to merge 1 commit intomosquito:masterfrom
Conversation
We have builds in different operating systems and compilers. On AlmaLinux 9 with Clang 19, importing `caio.linux_aio` fails because of two undefined symbols. Removing inline fixes the issue
Author
|
Could I get a review from @mosquito? |
Owner
|
I think the better solution is mark it as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have builds in different operating systems and compilers. On AlmaLinux 9 with Clang 19 (and also others but not every combination that we try), importing
caio.linux_aiofails because of two undefined symbols. Removing inline fixes the issue. I think it makes sense if they are to be used outside then they can't be inlined.This is the error: