MOTECH-2409 Updates to admin bundles#29
Conversation
Added statistics to bundles list, which also meant styling the motech-list header. added unstyled statistics bar for bundles list added dl-inline class moved bundle list into navbar
Added a filter input to the admin bundles list.
| <motech-list-header> | ||
| <form class="form-inline "> | ||
| <div class="form-group"> | ||
| <label for="admin.bundles.list.filter">{{msg('admin.filter')}}</label> |
There was a problem hiding this comment.
Shouldn't it be {{ 'admin.filter' | translate}} here and in all of the below lines?
|
@nickdotreid I've checked this PR and filter and showing some statistics about bundles works well. Are you going to work on how the header of the bundles list looks? I personally don't like the way it is now as the word Filter is above the filter input and maybe it is better to place them next to each other like fields in Email send form or Scheduler jobs form. Furthermore, I would move the statistics to the right to separate them from the filter. |
|
@jredlarski -- I was trying to keep with an inline form styling for the filter buttons... but I'll make the changes you suggested for the sake of consistency... |
|
@nickdotreid I based my opinion on that we used to place some buttons to the left and to the right within motech-list headers and I believe it is not such a bad pattern to place some data in the same way... |
|
test this please |
3 participants
This PR brings in items missing from the admin bundles package, that don't have other tickets.