MOTECH-2731: Migrate Module Settings#42
Conversation
matkwiatkowski
commented
Jul 26, 2016
matkwiatkowski
commented
- added module settings in admin
- added file-upload directive
- settings for task module still won't work, because task settings page isn't implemented yet
leftover comments removed
|
|
||
| LoadingModal.open(); | ||
|
|
||
| $(id).ajaxSubmit({ |
There was a problem hiding this comment.
As suggested in PR#39 we should not use JQueryFormPlugin as it is rather unsupported.
|
@mkwiatkowskisoldevelo Here are some issues that I have found in your PR: (1) We shouldn't use JQueryFormPlugin so lets drop that. |
|
Can one of the admins verify this patch? |
| <form id="_raw_{{rawFile}}" name="{{rawFile}}Form"> | ||
| <div class="form-group fileinput fileinput-new" data-provides="fileinput"> | ||
| <label>{{msg('admin.button.selectFile')}}</label> | ||
| <div class="col-sm-9 col-md-10"> |
There was a problem hiding this comment.
Try not to use the col- classes
|
@mkwiatkowskisoldevelo I've added a motech-file-upload directive in a separate PR so please use it and resolve any conflicts if they occur. |
| <li ui-sref-active="active"><a ui-sref="bundles">{{ 'admin.manageModules' | translate }}</a></li> | ||
| <li><a>{{ 'admin.messages' | translate }}</a></li> | ||
| <li><a>{{ 'admin.settings' | translate }}</a></li> | ||
| <li ui-sref-active="active"><a ui-sref="platformSettings">{{ 'admin.settings' | translate }}</a></li> |
There was a problem hiding this comment.
@mkwiatkowskisoldevelo Why did you add navigation to the settings page?
| function controller($scope, $stateParams, $http, BundleSettingsFactory, BundleRawSettingsFactory, LoadingModal, ModalFactory, BundlesFactory){ | ||
|
|
||
| var restartBundleHandler = function () { | ||
| $scope.module.$restart(); |
There was a problem hiding this comment.
Shouldn't it be $scope.module.restart();? Additionally, please check if modal appears after a successful restart.
4 participants
