Skip to content

Added empty list messages#81

Merged
jredlarski merged 4 commits into
motech:masterfrom
PJSosnowski:AddEmptyListMessages
Sep 2, 2016
Merged

Added empty list messages#81
jredlarski merged 4 commits into
motech:masterfrom
PJSosnowski:AddEmptyListMessages

Conversation

@PJSosnowski
Copy link
Copy Markdown
Contributor

@PJSosnowski PJSosnowski commented Sep 1, 2016

Added empty list messages where it was needed, as mentioned in #37

Please add the empty list warning to the rest of the lists in Motech in the second PR.

for proper working motech/motech#676 is required

@motech-gerrit
Copy link
Copy Markdown

Can one of the admins verify this patch?

@jredlarski
Copy link
Copy Markdown
Collaborator

test this please

@jredlarski jredlarski self-assigned this Sep 1, 2016
@jredlarski
Copy link
Copy Markdown
Collaborator

@PJSosnowski It looks good, what about the messages list in Admin Messages and bundles list in Admin Manage modules?

@PJSosnowski
Copy link
Copy Markdown
Contributor Author

@jredlarski messages list in Admin Messages already has this message, should I change it to be in the same manner?

@jredlarski
Copy link
Copy Markdown
Collaborator

@PJSosnowski Yes, it should look the same across all the lists in the UI

@jredlarski
Copy link
Copy Markdown
Collaborator

test this please

@jredlarski
Copy link
Copy Markdown
Collaborator

@PJSosnowski Please apply changes for the names of the variables which should be changed in motech/motech#676

@jredlarski
Copy link
Copy Markdown
Collaborator

test this please

@jredlarski
Copy link
Copy Markdown
Collaborator

test this please

@jredlarski jredlarski merged commit 5c0443a into motech:master Sep 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants