Skip to content

Fix reshare #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asabhaney wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix reshare #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92d160c
fix casting of bg colors from info.plist
asabhaney May 13, 2022
ec91c84
update docs
asabhaney May 13, 2022
e6c8ebf
allow to update delegate every time attachViewDelegate called
asabhaney May 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions SHARE_EXTENSION_VIEW.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,13 @@ Open your Share Extension's `Info.plist` and add the following:
<key>ReactShareViewBackgroundColor</key>
<dict>
<key>Red</key>
<integer>1</integer>
<real>1</real>
<key>Green</key>
<integer>1</integer>
<real>1</real>
<key>Blue</key>
<integer>1</integer>
<real>1</real>
<key>Alpha</key>
<integer>1</integer>
<real>1</real>
<key>Transparent</key>
<false/>
</dict>
Expand Down
2 changes: 1 addition & 1 deletion ios/Modules/ShareMenuReactView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public class ShareMenuReactView: NSObject {
}

public static func attachViewDelegate(_ delegate: ReactShareViewDelegate!) {
guard (ShareMenuReactView.viewDelegate == nil) else { return }
// guard (ShareMenuReactView.viewDelegate == nil) else { return }

ShareMenuReactView.viewDelegate = delegate
}
Expand Down
8 changes: 4 additions & 4 deletions ios/ReactShareViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ class ReactShareViewController: ShareViewController, RCTBridgeDelegate, ReactSha
break backgroundColorSetup
}

let red = backgroundColorConfig[COLOR_RED_KEY] as? Float ?? 1
let green = backgroundColorConfig[COLOR_GREEN_KEY] as? Float ?? 1
let blue = backgroundColorConfig[COLOR_BLUE_KEY] as? Float ?? 1
let alpha = backgroundColorConfig[COLOR_ALPHA_KEY] as? Float ?? 1
let red = (backgroundColorConfig[COLOR_RED_KEY] as? NSNumber)?.floatValue ?? 1
let green = (backgroundColorConfig[COLOR_GREEN_KEY] as? NSNumber)?.floatValue ?? 1
let blue = (backgroundColorConfig[COLOR_BLUE_KEY] as? NSNumber)?.floatValue ?? 1
let alpha = (backgroundColorConfig[COLOR_ALPHA_KEY] as? NSNumber)?.floatValue ?? 1

rootView.backgroundColor = UIColor(red: CGFloat(red), green: CGFloat(green), blue: CGFloat(blue), alpha: CGFloat(alpha))
}
Expand Down