test: localisaton tests are added based on features#77
Conversation
|
The test suite looks well organized and covers the main MotifProvider use cases nicely. createTranslator is tested well for locale resolution, parameter interpolation, custom text overrides, and fallback behavior. The MotifProvider tests also look good, especially the use of renderHook wrappers and act for state changes. The locale parity tests are also very useful. They can help catch missing translation keys between en and tr files in the future. The tests look clean and easy to maintain 👍 |
aktasmehmet
left a comment
There was a problem hiding this comment.
I didn't see any missing scenario, perfect work 💪
There are just my standard "I've reviewed this code" kind of requests :D
| "misc": { | ||
| "playgroundDescription": "This is the playground section to try your components..." | ||
| } | ||
| { |
There was a problem hiding this comment.
This diff should not be like this. There is only one line added but it looks like the whole file has changed. You may refer to the tr.json changes. This should be like that.
There was a problem hiding this comment.
I saw to same thing, looked up before but this 2 file is same with syntax and indent. I don't know how this en.json diff looks like this.
There was a problem hiding this comment.
I copied the diff one with the local one but only change is new value that I add.
Description
Localization tests are added with different scenarios based on our features.
createTranslator() unit tests (14 tests)
MotifProvider integration tests (12 tests)
Locale parity tests (4 tests)
Type of Change
Screenshots / Preview
Checklist
How to Test
npm run test:ci