Updating deps, adding more options, updating readme, fixing bugs and …#178
Open
michurin wants to merge 16 commits intomoul:masterfrom
Open
Updating deps, adding more options, updating readme, fixing bugs and …#178michurin wants to merge 16 commits intomoul:masterfrom
michurin wants to merge 16 commits intomoul:masterfrom
Conversation
Merged
|
New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
tsuna
pushed a commit
to tsuna/quicssh
that referenced
this pull request
Nov 26, 2025
- Add --sshdaddr flag to server for custom SSH daemon address - Add --localaddr flag to client for NAT punching support - Add QUIC keep-alive (5s) and idle timeout (10s) configuration - Improve error handling by removing sync.WaitGroup complexity - Use io.Copy for safer data transfer with 8KB buffers - Add version info and usage descriptions to CLI - Fix context package import (use stdlib instead of x/net) - Update README with new flags and corrected examples Cherry-picked from PR moul#178 by @michurin
tsuna
pushed a commit
to tsuna/quicssh
that referenced
this pull request
Nov 26, 2025
- Add --sshdaddr flag to server for custom SSH daemon address - Add --localaddr flag to client for NAT punching support - Add QUIC keep-alive (5s) and idle timeout (10s) configuration - Improve error handling by removing sync.WaitGroup complexity - Use io.Copy for safer data transfer with 8KB buffers - Add version info and usage descriptions to CLI - Fix context package import (use stdlib instead of x/net) - Update README with new flags and corrected examples Cherry-picked from PR moul#178 by @michurin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I'm not sure this project is supported, and I didn't check other pull requests. However, I would like to share this update.
Changes:
--sshdaddr(in casesshdis running on nonstandard port or on other host)--localaddr(it gives an ability to specify source UDP port, it is useful in case you use net punching over firewalls and NATs)--versionio.Copy)I would like to keep playing with this bunch of code. Improve error handling, write tests... Would you vote for this?
upd
upd2
I enriched logging and error. You can see changes here michurin#2. However, it looks like subject of next poll request.
upd3
Dependencies has to be updated again :-) michurin#5
upd4
One more nice to be stolen thing michurin#7. Prevention of 100% CPU consumption on server side in case of some errors: context canceled, port already occupied, lack of process permissions...
upd5
Migrate github.com/urfave/cli/v2 -> v3, according suggestion #179 — michurin#10
upd6
By the way, it could be nice to use session context in session handler — https://github.com/michurin/quicssh/pull/11/files#diff-366e46a40f6f60b4f7614eb0976bb51820364bf5ca6ccc4787eb49d7bdbef3e6R69
upd7
Added
--idletimeoutoption. Useful for coupling quicssh with netpunching. Also added behavioral test. michurin#8