fix: set expiration for artifacts in linting and release notes configurations#15
fix: set expiration for artifacts in linting and release notes configurations#15konradmichalik merged 1 commit intomainfrom
Conversation
WalkthroughExpiration times of one day have been added to artifact storage in three CI pipeline YAML files: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
analyze/analyze-style-lint.yaml (1)
15-19: Same TTL duplication as in JS lint jobThe observation and suggestion given in the previous file (parameterising or anchoring
expire_in) applies here as well, so I won’t repeat the details.
🧹 Nitpick comments (1)
analyze/analyze-js-lint.yaml (1)
15-19: Consider parameterising artifact TTL to avoid hard-coding “1 day” in multiple jobs
expire_in: 1 dayis perfectly valid, but the same literal now appears in several pipeline configs. Introducing a global variable (e.g.ARTIFACT_TTL, or a YAML anchor/alias) would keep the value DRY and simplify future changes.Example (variable):
- expire_in: 1 day + expire_in: ${ARTIFACT_TTL:-1 day} # default to 1 day if not overriddenExample (YAML anchor):
.defaults: &artifact_defaults expire_in: 1 day artifacts: <<: *artifact_defaults paths: - node_modules/
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
analyze/analyze-js-lint.yaml(1 hunks)analyze/analyze-style-lint.yaml(1 hunks)build/build-release-notes.yaml(1 hunks)
🔇 Additional comments (1)
build/build-release-notes.yaml (1)
18-22: Verify whether a 1-day retention is sufficient for release-note artifactsRelease notes can be useful for auditors or late-joiners after the pipeline finishes. Reducing retention from GitLab’s default (30 days) to 1 day may make older release artifacts unavailable.
If the short TTL is intentional (e.g. notes are copied elsewhere), no action needed; otherwise consider extending to 7-30 days or pushing the file to the project’s Releases so it is stored outside the job artifacts area.
- expire_in: 1 day +# expire_in: 7 days # example if longer retention is preferred
Summary by CodeRabbit