Dev/weird test#16
Open
DawidStuzynski wants to merge 5 commits into
Open
Conversation
Comment on lines
+9
to
+19
| static jobOffer(args = [:]) { | ||
| new JobOffer( | ||
| 'id' in args.keySet() ? args.id as String : 'test-id', | ||
| 'title' in args.keySet() ? args.title as String : 'test-title', | ||
| 'companyName' in args.keySet() ? args.companyName as String : 'test-company', | ||
| 'experience' in args.keySet() ? args.experience as String : 'test-experience', | ||
| 'skills' in args.keySet() ? args.skills as List<Skill> : [], | ||
| 'employmentType' in args.keySet() ? args.employmentType as List<EmploymentType> : [], | ||
| 'remote' in args.keySet() ? args.remote as boolean : true | ||
| ) | ||
| } |
Member
There was a problem hiding this comment.
What do you think about simplifying this code?
Suggested change
| static jobOffer(args = [:]) { | |
| new JobOffer( | |
| 'id' in args.keySet() ? args.id as String : 'test-id', | |
| 'title' in args.keySet() ? args.title as String : 'test-title', | |
| 'companyName' in args.keySet() ? args.companyName as String : 'test-company', | |
| 'experience' in args.keySet() ? args.experience as String : 'test-experience', | |
| 'skills' in args.keySet() ? args.skills as List<Skill> : [], | |
| 'employmentType' in args.keySet() ? args.employmentType as List<EmploymentType> : [], | |
| 'remote' in args.keySet() ? args.remote as boolean : true | |
| ) | |
| } | |
| static jobOffer(args = [:]) { | |
| new JobOffer( | |
| args.id as String ?: 'test-id', | |
| args.title as String ?: 'test-title', | |
| args.companyName as String ?: 'test-company', | |
| args.experience as String ?: 'test-experience', | |
| args.skills as List<Skill> ?: [], | |
| args.employmentType as List<EmploymentType> ?: [], | |
| args.remote as boolean ?: true | |
| ) | |
| } |
Comment on lines
+15
to
+16
| 'skills' in args.keySet() ? args.skills as List<Skill> : [], | ||
| 'employmentType' in args.keySet() ? args.employmentType as List<EmploymentType> : [], |
Member
There was a problem hiding this comment.
I suggest filling these fields with additional data instead of empty lists.
| ) | ||
| } | ||
|
|
||
| static List<JobOffer> createListJobOffers(int count) { |
Member
There was a problem hiding this comment.
The name of the function "createListJobOffers" may not reflect the intent well, as it may be associated with creating a list and storing it in a database, which is not the case here. I propose the same naming convention as above ie: jobOffersList
Comment on lines
+21
to
+25
| static List<JobOffer> createListJobOffers(int count) { | ||
| return (1..count).collect { _ -> | ||
| jobOffer() | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
You can simplify things a bit
Suggested change
| static List<JobOffer> createListJobOffers(int count) { | |
| return (1..count).collect { _ -> | |
| jobOffer() | |
| } | |
| } | |
| static jobOfferList(int count) { | |
| (1..count).collect { jobOffer() } | |
| } |
|
|
||
| def "publish should chunk job offers and publish them to the queue"() { | ||
| given: | ||
| List<JobOffer> jobOffers = JobFixture.createListJobOffers(10) |
Member
There was a problem hiding this comment.
Please use static import
import static it.move2.agent.application.JobFixture.createListJobOffers
Suggested change
| List<JobOffer> jobOffers = JobFixture.createListJobOffers(10) | |
| def jobOffers = createListJobOffers(10) |
| jobBoard1 = Mock() | ||
| jobBoard2 = Mock() | ||
| queue = Mock() | ||
| objectMapper = new ObjectMapper() |
Member
There was a problem hiding this comment.
How about using the same ObjectMapper that is used in the code from the Bootstrap class? Currently, this ObjectMapper is configured a bit different in tests than in the production version, which may not reveal all the bugs.
| def jobs1 = [JobFixture.jobOffer(), JobFixture.jobOffer()] | ||
|
|
||
| jobBoard1.getJobs() >> jobs1 | ||
| jobBoard2.getJobs() >> { throw new RuntimeException("Test error message") } |
Member
There was a problem hiding this comment.
How is error handling carried out in the application? I haven't seen anything throwing an exception.
| jobBoard2.getJobs() >> { throw new RuntimeException("Test error message") } | ||
|
|
||
| when: | ||
| updater.execute() |
Member
There was a problem hiding this comment.
Suggested change
| updater.execute() | |
| updater.execute() |
|
|
||
| then: | ||
| thrown(RuntimeException) | ||
| 0 * queue.pub(_) >> {} |
Member
There was a problem hiding this comment.
Suggested change
| 0 * queue.pub(_) >> {} | |
| 0 * queue.pub(_) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement tests for application package