chore: track poetry.lock for reproducible dependency resolution#286
Merged
Conversation
Addresses the SonarCloud finding on PR mozarkai#285 that flagged the missing lock file: "Dependency versions are not predictable if the lock file (uv.lock or poetry.lock) is missing." - .gitignore: comment out the `poetry.lock` line so poetry.lock is no longer ignored. - poetry.lock: add the freshly-generated lock file (poetry 2.4.1) pinning the full dependency graph resolved against pyproject.toml. Going forward, dependency changes should bump pyproject.toml and re-run `poetry lock` so the lock file stays in sync. CI builds and contributor checkouts will now resolve to identical versions.
|
thakur-patel
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the SonarCloud finding on PR #285 that flagged the missing lock file: "Dependency versions are not predictable if the lock file (uv.lock or poetry.lock) is missing."
poetry.lockline so poetry.lock is no longer ignored.Going forward, dependency changes should bump pyproject.toml and re-run
poetry lockso the lock file stays in sync. CI builds and contributor checkouts will now resolve to identical versions.