config: update with bmo data again after parsing modules (bug 1797102)#34
Draft
config: update with bmo data again after parsing modules (bug 1797102)#34
Conversation
zzzeid
force-pushed
the
zeid/bug-1797102-update-with-bmo-after-parsing
branch
4 times, most recently
from
13c3c91 to
b374134
Compare
zzzeid
changed the base branch from
zeid/bug-1797083-key-error-with-no-nick
to
main
- make `Person.nick` and `Person.name` optional, default to empty string - serialize newly added persons before adding to people entry - add test to test Person class
- update using bmo data after parsing modules - ensure only unique people are added to people list - add test that mocks get_bmo_data to avoid requiring API call
zzzeid
force-pushed
the
zeid/bug-1797102-update-with-bmo-after-parsing
branch
from
b374134 to
9dc4a01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.