fix: add settings for FxA acct event SET aud and iss#2393
Open
chenba wants to merge 3 commits into
Open
Conversation
chenba
force-pushed
the
fix/webhook-set-aud-iss-settings
branch
from
af475bd to
1695e1e
Compare
taddes
reviewed
Jun 16, 2026
| pub init_node_capacity: i32, | ||
| /// Whether to enable the FxA webhook endpoint. | ||
| /// Defaults to false. | ||
| pub fxa_webhook_enabled: bool, |
Collaborator
There was a problem hiding this comment.
Possibly forgive my ignorance, but if fxa_webhook_enabled = true but the new set vars are unset, is it that the webhook accepts requests but has zero verifiers? Would it still work? I wonder if for a follow up it might make sense to have some error handling around that
Collaborator
Author
There was a problem hiding this comment.
An http 401 is returned from the extractor if there are no verifiers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding two settings for account event SET validation
Issue(s)
Fixes STOR-606