Skip to content

Conversation

@groovecoder
Copy link
Member

@groovecoder groovecoder commented Jan 15, 2026

Pull Request checklist

  • Breaking changes: This PR follows our breaking change policy
    • This PR follows the breaking change policy:
      • This PR has no breaking API changes
  • Quality: This PR builds and tests run cleanly
  • Tests: This PR includes thorough tests
  • Changelog: This PR includes a changelog entry in CHANGELOG.md
  • Dependencies: This PR follows our dependency management guidelines

@groovecoder groovecoder force-pushed the relay-add-custom-header-MPP-4539 branch 5 times, most recently from 4104dcd to 2b94a93 Compare January 20, 2026 22:56
@groovecoder groovecoder marked this pull request as ready for review January 20, 2026 22:57
Copy link
Collaborator

@jonalmeida jonalmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the mobile client perspective, this looks fine. Thanks!

if let Some(ref token) = self.auth_token {
request = request.header(header_names::AUTHORIZATION, format!("Bearer {}", token))?;
}
request = request.header("X-Relay-Client", format!("appservices-{}", std::env::consts::OS))?;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@groovecoder groovecoder force-pushed the relay-add-custom-header-MPP-4539 branch from 2b94a93 to b7032dc Compare January 21, 2026 16:50
Value is hard-coded to `appservices-{OS}`
@groovecoder groovecoder force-pushed the relay-add-custom-header-MPP-4539 branch from b7032dc to e6cdc34 Compare January 21, 2026 17:01
@groovecoder groovecoder added this pull request to the merge queue Jan 21, 2026
Merged via the queue into main with commit 451b391 Jan 21, 2026
13 checks passed
@groovecoder groovecoder deleted the relay-add-custom-header-MPP-4539 branch January 21, 2026 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants