[DENG-10877] Support v1 glean tables that use the v2 schema#9233
Draft
BenWu wants to merge 2 commits into
Draft
Conversation
This comment has been minimized.
This comment has been minimized.
0ada899 to
c8e8fc6
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Integration report for "DENG-10877 Support v1 glean tables that use the v2 schema"
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With mozilla/mozilla-schema-generator#315, v1 tables will be replaced and use the
glean/ping/2. sql_generators relying on the schema_id need to be updated. https://github.com/mozilla/bigquery-etl/pull/9190/changes already updatedget_stable_table_schemas()to not return the v2 tables.Related Tickets & Documents
Reviewer, please follow this checklist