Skip to content

Update Slack notification channel for Ads Client#9348

Open
Almaju wants to merge 1 commit into
mainfrom
ads-client-slack
Open

Update Slack notification channel for Ads Client#9348
Almaju wants to merge 1 commit into
mainfrom
ads-client-slack

Conversation

@Almaju
Copy link
Copy Markdown
Contributor

@Almaju Almaju commented May 11, 2026

Description

We will use directly our internal channel instead of a dedicated notification channel.

@Almaju Almaju enabled auto-merge May 11, 2026 17:52
@Almaju Almaju requested a review from doomsuckle May 11, 2026 17:52
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Scope: one-line change to notification_channels in a Bigeye bigconfig.yml, redirecting alerts from #ads-client-notifications to #ads-client-owners. No SQL, schema, or pipeline behavior is touched, so the reviewer checklist items around query correctness, schema changes, scheduling, and backfills are not applicable here.

Observations:

  • The change is mechanically clean: indentation, quoting, and YAML structure match the surrounding file, and the rest of the deployment block is untouched.
  • note: The PR description still contains the placeholder ticket references DENG-XXXX / DSRE-XXXX. Worth filling in (or removing) before merge so the change is traceable to whatever request prompted the channel swap.
  • question (inline): Worth confirming the new channel exists and that the Bigeye integration is wired up to it before this lands, since misconfigured alert routing tends to fail silently.

Otherwise this looks fine to ship once those are confirmed.

name: Ads Client
notification_channels:
- slack: '#ads-client-notifications'
- slack: '#ads-client-owners'
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Confirm that #ads-client-owners already exists in Slack and that the Bigeye integration (or whichever service consumes these notification_channels) has been invited / has permission to post there — otherwise routing will silently break the moment this is deployed. Also worth verifying that the previous channel (#ads-client-notifications) is intentionally being abandoned rather than added alongside.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm the BigEye integration was registered on this channel!

@github-actions
Copy link
Copy Markdown

Integration report for "Update Slack notification channel for Ads Client"

sql.diff

Click to expand!
diff -bur --no-dereference --new-file /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/ads_derived/ads_client_operations_and_errors_hourly_v1/bigconfig.yml /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/ads_derived/ads_client_operations_and_errors_hourly_v1/bigconfig.yml
--- /tmp/workspace/main-generated-sql/sql/moz-fx-data-shared-prod/ads_derived/ads_client_operations_and_errors_hourly_v1/bigconfig.yml	2026-05-11 18:00:42.011849001 +0000
+++ /tmp/workspace/generated-sql/sql/moz-fx-data-shared-prod/ads_derived/ads_client_operations_and_errors_hourly_v1/bigconfig.yml	2026-05-11 18:00:38.119764685 +0000
@@ -3,7 +3,7 @@
 - collection:
     name: Ads Client
     notification_channels:
-    - slack: '#ads-client-notifications'
+    - slack: '#ads-client-owners'
   deployments:
   - column_selectors:
     - name: moz-fx-data-shared-prod.moz-fx-data-shared-prod.ads_derived.ads_client_operations_and_errors_hourly_v1.*

Link to full diff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant