Update Slack notification channel for Ads Client#9348
Conversation
There was a problem hiding this comment.
Scope: one-line change to notification_channels in a Bigeye bigconfig.yml, redirecting alerts from #ads-client-notifications to #ads-client-owners. No SQL, schema, or pipeline behavior is touched, so the reviewer checklist items around query correctness, schema changes, scheduling, and backfills are not applicable here.
Observations:
- The change is mechanically clean: indentation, quoting, and YAML structure match the surrounding file, and the rest of the deployment block is untouched.
- note: The PR description still contains the placeholder ticket references
DENG-XXXX/DSRE-XXXX. Worth filling in (or removing) before merge so the change is traceable to whatever request prompted the channel swap. - question (inline): Worth confirming the new channel exists and that the Bigeye integration is wired up to it before this lands, since misconfigured alert routing tends to fail silently.
Otherwise this looks fine to ship once those are confirmed.
| name: Ads Client | ||
| notification_channels: | ||
| - slack: '#ads-client-notifications' | ||
| - slack: '#ads-client-owners' |
There was a problem hiding this comment.
question: Confirm that #ads-client-owners already exists in Slack and that the Bigeye integration (or whichever service consumes these notification_channels) has been invited / has permission to post there — otherwise routing will silently break the moment this is deployed. Also worth verifying that the previous channel (#ads-client-notifications) is intentionally being abandoned rather than added alongside.
There was a problem hiding this comment.
I confirm the BigEye integration was registered on this channel!
Integration report for "Update Slack notification channel for Ads Client"
|
Description
We will use directly our internal channel instead of a dedicated notification channel.