Skip to content

Remove unreachable exception in code_review_bot.__init__ #3339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vrigal wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −2
Open

Remove unreachable exception in code_review_bot.__init__ #3339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions bot/code_review_bot/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,8 +205,7 @@ def hash(self):
), "Github cache repository is mandatory to analyse a github revision"
local_repository = settings.git_cache / self.revision.repository_slug
else:
raise Exception(self.revision.__class__)
raise NotImplementedError
raise NotImplementedError(self.revision.__class__)

# Build the hash only if the file is not autogenerated.
# An autogenerated file resides in the build directory that it has the
Expand Down