Fix too strict typing of view functions in decorators#282
Open
bluetech wants to merge 2 commits intomozilla:mainfrom
Open
Fix too strict typing of view functions in decorators#282bluetech wants to merge 2 commits intomozilla:mainfrom
bluetech wants to merge 2 commits intomozilla:mainfrom
Conversation
View functions can have additional parameters if the URL has parameters. Currently these are not allowed by the typing even though the code itself handles them just fine. Expand the view type to match what django-stubs is using e.g. here: https://github.com/typeddjango/django-stubs/blob/fb310b1b0b40c666c156f0943804f3791ff48f95/django-stubs/urls/conf.pyi#L18
robhudson
approved these changes
Jun 17, 2025
Collaborator
robhudson
left a comment
robhudson
left a comment
There was a problem hiding this comment.
Thanks for catching and submitting a PR.
Contributor
|
@robhudson OK to merge? I trust your |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View functions can have additional parameters if the URL has parameters.
Currently these are not allowed by the typing even though the code
itself handles them just fine.
Expand the view type to match what django-stubs is using e.g. here:
https://github.com/typeddjango/django-stubs/blob/fb310b1b0b40c666c156f0943804f3791ff48f95/django-stubs/urls/conf.pyi#L18