Draft
Conversation
The std HashMap uses hashbrown these days, so I think this won't make anything slower. But I haven't tested it.
Collaborator
|
There is a small difference between the hashing algorithm:
And if I remember correctly, I chose the second because it was slightly faster and because we don't care about HashDoS attacks. |
Collaborator
Author
|
Ah, thanks for checking! Then maybe we can use the regular HashMap with a different hasher, or even I'll do a speed comparison when I get a chance. For now we can just ignore this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The std HashMap uses hashbrown these days, so I think this won't make anything slower. But I haven't tested it.