Skip to content

feat: add ContentAnalysis/MaxConnectionsCount#61

Merged
bsmth merged 3 commits intomozilla:mainfrom
bsmth:ContentAnalysis-MaxConnectionsCount
Feb 24, 2026
Merged

feat: add ContentAnalysis/MaxConnectionsCount#61
bsmth merged 3 commits intomozilla:mainfrom
bsmth:ContentAnalysis-MaxConnectionsCount

Conversation

@bsmth
Copy link
Collaborator

@bsmth bsmth commented Feb 23, 2026

Description:

Adding ContentAnalysis/MaxConnectionsCount

Motivation:

MaxConnectionsCount is missing from the ContentAnalysis page

Related issues and pull requests:

Fixes #58

See also:

@bsmth bsmth changed the title feat: add ContentAnalysis/ContentAnalysis feat: add ContentAnalysis/MaxConnectionsCount Feb 23, 2026
@bsmth bsmth requested a review from mkaply February 23, 2026 11:26
Copy link
Contributor

@mkaply mkaply left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what we should use for arbitrary numbers.

0x is hex,. so that isn't right I think

Software\Policies\Mozilla\Firefox\ContentAnalysis\InterceptionPoints\FileUpload\Enabled = 0x1 | 0x0
Software\Policies\Mozilla\Firefox\ContentAnalysis\InterceptionPoints\Print\Enabled = 0x1 | 0x0
Software\Policies\Mozilla\Firefox\ContentAnalysis\IsPerUser = 0x1 | 0x0
Software\Policies\Mozilla\Firefox\ContentAnalysis\MaxConnectionsCount = 0x0 | 0x1 | 0x2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't right because it can be an arbitrary number.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated in 88e9e6b

@mkaply
Copy link
Contributor

mkaply commented Feb 23, 2026

DLP team likes it, but default value should be 32, not 3.

Let's just use 32 everywhere instead of 0x0 | 0x1 | 0x2

@bsmth
Copy link
Collaborator Author

bsmth commented Feb 24, 2026

DLP team likes it, but default value should be 32, not 3.

Let's just use 32 everywhere instead of 0x0 | 0x1 | 0x2

Thank you! Pushed a small update in 88e9e6b

@bsmth bsmth requested a review from mkaply February 24, 2026 08:43
@bsmth bsmth merged commit e37fcab into mozilla:main Feb 24, 2026
1 check passed
@bsmth bsmth deleted the ContentAnalysis-MaxConnectionsCount branch February 24, 2026 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ContentAnalysis: MaxConnectionsCount missing

2 participants