feat(settings): add card border to split layout and center loading spinner#20065
Open
MagentaManifold wants to merge 1 commit intomainfrom
Open
feat(settings): add card border to split layout and center loading spinner#20065MagentaManifold wants to merge 1 commit intomainfrom
MagentaManifold wants to merge 1 commit intomainfrom
Conversation
LZoog
reviewed
Feb 25, 2026
packages/fxa-react/styles/flows.css
Outdated
| } | ||
| .card, | ||
| .card-split-layout { | ||
| @apply w-full border border-transparent mobileLandscape:w-120 mobileLandscape:bg-white rounded-xl px-6 py-8 mobileLandscape:px-8 mobileLandscape:py-9 mobileLandscape:mb-6; |
Contributor
There was a problem hiding this comment.
What do you think about us copying what we do for our CTAs, e.g. create a card-base for all shared classes, and then @apply that to card and card-split-layout?
MagentaManifold
force-pushed
the
FXA-13007
branch
2 times, most recently
from
c0a8f9a to
1dc4f23
Compare
…inner Because: * loading spinner in split layout is off-centered * Ross want card border in split layout This commit: * adds card border to split layout and centers loading spinner Closes FXA-13007
MagentaManifold
force-pushed
the
FXA-13007
branch
from
1dc4f23 to
7939ed8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-13007
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Other information (Optional)
Any other information that is important to this pull request.