fix(settings): fix metrics not always emitted for third party auth#20087
Open
MagentaManifold wants to merge 1 commit intomainfrom
Open
fix(settings): fix metrics not always emitted for third party auth#20087MagentaManifold wants to merge 1 commit intomainfrom
MagentaManifold wants to merge 1 commit intomainfrom
Conversation
vbudhram
reviewed
Feb 24, 2026
Contributor
vbudhram
left a comment
vbudhram
left a comment
There was a problem hiding this comment.
@MagentaManifold Do you see the metrics get posted? When I went through the flow they didn't complete
Contributor
Author
|
Whoops, I thought that means metrics are sent. Maybe this is not working. I gotta do more testing... |
Because: * metrics not always emitted for third party auth This commit: * avoids using <form> for navigation Closes FXA-12949
MagentaManifold
force-pushed
the
FXA-12949
branch
from
37bd383 to
1fd932f
Compare
Contributor
Author
|
@vbudhram Hi! I have done some more testing, and it turns out that although it seems that the request did not complete in the devtool network tab, the server actually can receive those pings. I have verified this through Glean Debug Ping Viewer EDIT: actually, it seems that it's working even without this fix applied... So this could be a nonissue to start with. Nevertheless, the old code is unnecessarily complex, and it's still beneficial to merge this refactor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
Issue that this pull request solves
Closes: FXA-12949
Checklist
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
Any other information that is important to this pull request.