feat(fxa): Pass WAF bypass token with functional-test auth-client#20108
Merged
feat(fxa): Pass WAF bypass token with functional-test auth-client#20108
Conversation
dschom
approved these changes
Feb 26, 2026
Because: - Some functional tests make use of the auth-client for direct calls to the auth-server - And we want to enable blocking direct requests to the auth-server This commit: - Passes a unique token to the auth-client requests that are blocking to enable bypassing the rule Closes:
ba44b08 to
4156eb6
Compare
Contributor
Author
|
Last force push after approval was just to add the header to one other place that I missed. |
toufali
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because:
This commit:
Closes: FXA-13195
Put an
xin the boxes that applyScreenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
I tested this locally by pointing functional tests at stage while the blocking rule was active to ensure we get the
406response, then with the correct environment variables provided the header is added and the test passes